getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

[Feature] Suggest LN addresses when making a payment #1971

Open alex-klyuev opened 1 year ago

alex-klyuev commented 1 year ago

Feature description

When sending from the view below, we can provide suggestions to existing LN addresses:

Screenshot 2023-01-12 at 12 26 56 PM

Could be done as a dropdown, with options being filtered as user types.

Describe the solution

Not sure which is desired:

  1. Suggest LN addresses that this user has previously sent to
  2. Suggest from all saved LN addresses within Alby (would require an API call, perhaps privacy issue also?)

For 1, would require saving LN addresses locally, as suggested here: https://github.com/getAlby/lightning-browser-extension/pull/1970

aayyuussh commented 1 year ago

I am working on this

aayyuussh commented 1 year ago

Here are few changes to the design to make it more convenient for the users:

You can see the changes here (or in Figma file)

Final (4)

For light mode: Group 2525

For dark mode: send_with_lightning_addresses

List item Colors: image

Text Color: image

Rithvik-padma commented 1 year ago

@rolznz @bumi I would like to work on this issue for the hacktoberfest. Can you provide a bit more context about this issue and how to approach it on a high level. Thanks!

rolznz commented 1 year ago

There was an old PR that seems like it never went anywhere https://github.com/getAlby/lightning-browser-extension/pull/2121

I think this task is quite complex and needs review/design from the Alby team before beginning. CC @reneaaron

@Rithvik-padma unfortunately I don't think this can be worked on yet, I'll remove the tag. Sorry!

Rithvik-padma commented 1 year ago

There was an old PR that seems like it never went anywhere https://github.com/getAlby/lightning-browser-extension/pull/2121

  • It is probably best to update the DB to include a contacts list table rather than just saving lightning address on payments
  • It seems like we need UI for saving and managing contacts, unless we do it automatically for now (but allow removing entries from recent history)

I think this task is quite complex and needs review/design from the Alby team before beginning. CC @reneaaron

@Rithvik-padma unfortunately I don't think this can be worked on yet, I'll remove the tag. Sorry!

Sure got it!

umarluqman commented 10 months ago

Is this issue can be worked on now?

stackingsaunter commented 5 months ago

@umarluqman sorry for late replay. It isn't, If you'd like to grab it!

jpl-btc commented 5 months ago

Alongside the recent contact list, consider adding an optional "Nostr Contact List" tab. This tab could feature either your followers or the contacts you are following and include a search bar for quick name lookup. Screenshot 05-17-2024 14 29 47

stackingsaunter commented 5 months ago

@JPLACLAU this can't be easily done because that would require extension to receive messages from Nostr protocol, which is a big change to current architecture.