getAlby / lightning-browser-extension

The Bitcoin Lightning Browser extension that connects to different wallet interfaces and brings deep lightning integration to the web
https://getalby.com
MIT License
530 stars 193 forks source link

[BUG] Confirmation dialog size too big for extension popup #2378

Open mquasar opened 1 year ago

mquasar commented 1 year ago

Is there an existing issue for this?

Describe the bug

When deleting an allowance from the extension popup, confirmation dialog extends beyond UI boundaries.

Screenshots [optional]

image

image

Steps To Reproduce

  1. Visit a connected website, for example, GetAlby
  2. Open extension from extension toolbar icon
  3. On the allowance section, click on the settings icon
  4. Click on delete

Expected behavior

The confirmation dialog should appear within the boundaries of the extension. Another approach could be opening the allowance settings in a new tab with more room, just like the websites menu item, for instance.

Alby information

Device information

Additional context

No response

Are you working on this?

None

mquasar commented 1 year ago

image

I tried this on Brave and the behavior is slightly different. The dialog shows on top of the extension and decentralized.

fczuardi commented 1 year ago

Looking at the code, this dialog is a native one from the browser, a window.confirm, so the behavior will vary between browser implementations...

mquasar commented 1 year ago

Wonder if this is by design or if it could be changed to a more customizable approach. 🤔

im-adithya commented 1 year ago

this dialog is a native one from the browser, a window.confirm

Yes, this although can be replaced by a custom popup, but is it worth the effort? // @stackingsaunter @bumi

stackingsaunter commented 1 year ago

I am currently redesigning this part of the extension and I am going to propose not allowing to delete the website connection in the popup (since it deletes the whole connection, not allowence). Then the problem will disappear