fix lnurl channel - Githubissues

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.

https://getalby.com/#extension

MIT License

539 stars 194 forks source link

fix lnurl channel #3046

Closed pavanjoshi914 closed 9 months ago

pavanjoshi914 commented 9 months ago

show proper error messages

Describe the changes you have made in this PR

fix lnurl callback proper error messages while doing requests

Type of change

(Remove other not matching type)

fix: Bug fix (non-breaking change which fixes an issue)

Checklist

[X] Self-review of changed code
[X] Manual testing
[X] Added automated tests where applicable
[X] Update Docs & Guides
For UI-related changes
[X] Darkmode
[X] Responsive layout

pavanjoshi914 commented 9 months ago

sry i just quickly coded it. need to improve the pr a bit. thanks for the review addressing it

pavanjoshi914 commented 9 months ago

will merge this. i think functionality is complete now. if there are further improvements we need to do. i can do a follow up pr