getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

fix: styling and other issues on Apple Devices #3065

Closed im-adithya closed 8 months ago

im-adithya commented 8 months ago

Describe the changes you have made in this PR

Common changes among iOS, iPad and Mac (Safari only)

Fixes blank screen issue on start page Prevents Start Page(s) from being removed resulting in closing of Safari while locking the extension

iOS

Replaces w-96 with w-full

iPad

Removes max-w-full as that is disturbing the popup size

Type of change

(Remove other not matching type)

Screenshots of the changes [optional]

How has this been tested?

Manually

Checklist

pavanjoshi914 commented 8 months ago

it breaks for firefox and firefox for android

is there any way to inspect popup on ios. is that popup somehow scrollable? we need to keep fix width for the popup and not adaptive width. we will never know which browser will break this changes it also depends on version. for eg. older browser version newer browser version. the rendering is different. maybe we shall avoid touching core template and see if we can fix the screen to adapt to ios and other browsers

image