search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

[BUG] Payment success with NaN sats for Zeus notes #3067

Open ekzyis opened 8 months ago

ekzyis commented 8 months ago

Is there an existing issue for this?

Searched for NaN but there were no open issues, just some closed ones.

Describe the bug

I tried to zap this note from Zeus with Primal and the Alby extension.

After an unusual amount of time after confirming the zap in the Alby popup, the zap "succeeded" but I am not sure. It said "NaN sats". Tried again to see if it would happen again and it did:

Screenshots [optional]

2024-03-06-232637_384x599_scrot

2024-03-06-233225_395x607_scrot

Steps To Reproduce

  1. Visit https://primal.net/e/note1zr92nfc080mgqgrs24drqh0mzfu36y2c6v6lc3mp626z83lwlwqs8ux23z
  2. Zap

Expected behavior

Payment succeeds without NaN

Alby information

Device information

Additional context

No response

Are you working on this?

None

reneaaron commented 8 months ago

@ekzyis Which connector do you use? Is that your Alby account?

ekzyis commented 8 months ago

Yes, this is my Alby account

Which connector do you use

It wasn't NWC but just a payment from my custodial Alby wallet, I believe.

Update: It's specific to this note or nostr account. Just tested zapping with this note and it worked as expected (very fast success without NaN). Still happens with that Zeus note though. Actually seems to happen with every note from npub1xnf02f60r9v0e5kty33a404dm79zr7z2eepyrk5gsq3m7pwvsz2sazlpr5. So it might be related to Zeus using HODL invoices? I think I heard something like that somewhere.