getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

feat: update extension settings layout #3069

Closed amitamrutiya closed 6 months ago

amitamrutiya commented 8 months ago

Describe the changes you have made in this PR

I have implemented the recommended changes mentioned in the issue. In this PR I make sure that:

Link this PR to an issue [optional]

2874

Fixes #2874

Type of change

Screenshots of the changes [optional]

image

Checklist

stackingsaunter commented 8 months ago

Hey @amitamrutiya2210 are you still working on this one?

amitamrutiya commented 8 months ago

From my side, the work is done. So, this PR is ready for review.

stackingsaunter commented 8 months ago

@amitamrutiya2210 I see thanks 🙏🙏

pavanjoshi914 commented 7 months ago

Thanks for the pr! fixed some layout issues and styles and code conventions. @reneaaron let me know if want some additional changes!

TODO: update wallet settings this focus only on extension settings

pavanjoshi914 commented 7 months ago

Rest LGTM!

pavanjoshi914 commented 6 months ago

regarding outdated translations warnings. i don't think we shall remove it. it's just that strings were capitalised in English version

pavanjoshi914 commented 6 months ago

tAck