getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

[Feature] Add support for denying a sign request and remember #3110

Closed vicariousdrama closed 5 months ago

vicariousdrama commented 7 months ago

Feature description

When visiting some web applications, I am confronted with requests to sign events that I don't want to, and never want to. For example,

The browser extension has an option to remember my choice and don't ask again, but this only applies when continuing with the signing event.

image

Describe the solution

Add another button next to Cancel, or a Drop Down from Cancel to "Deny". If a signing event is denied, and not simply cancelled, then take into account whether the checkbox to remember my choice is checked and apply to future requests of the same kind.

Describe alternatives

No response

Additional context

No response

Are you working on this?

No

reneaaron commented 7 months ago

@vicariousdrama Thanks for your feedback, I totally understand that this a pain currently.

We already have plans to improve on that, hopefully we'll be able to include it in the next release coming up in the next month.

reneaaron commented 5 months ago

This has been included in the latest release. Feel free to check it out!