getAlby / lightning-browser-extension

The Bitcoin Lightning Browser extension that connects to different wallet interfaces and brings deep lightning integration to the web
https://getalby.com
MIT License
524 stars 192 forks source link

feat: unchain unlock call from enable screen #3143

Closed pavanjoshi914 closed 1 month ago

pavanjoshi914 commented 1 month ago

Describe the changes you have made in this PR

unchain unlock screen from enable screen

Link this PR to an issue [optional]

fixes triggering of enable screen for nostr when extension is locked, even if the provider was persisted before. this also reduces the side effect of user needed to set permission again because of retriggering of enable screens

Type of change

(Remove other not matching type)

Checklist

reneaaron commented 1 month ago

Tested and worked like intended. :+1:

There is still a bug when you manually lock the extension after you enabled it on this website before, which leads to an erroneous state in the extension (you need to manually reload it afterwards in order to use it again). This bug was already in there for years though, so I don't think we need to fix that in this PR.

tACK