feat: revamp-nostr-settings

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.

https://getalby.com/#extension

MIT License

532 stars 193 forks source link

feat: revamp-nostr-settings #3147

Closed pavanjoshi914 closed 4 months ago

pavanjoshi914 commented 4 months ago

Describe the changes you have made in this PR

new ui for nostr settings page

Link this PR to an issue [optional]

(Remove other not matching type)

feat: New feature (non-breaking change which adds functionality)

Checklist

[X] Self-review of changed code
[X] Manual testing
[X] Added automated tests where applicable
[X] Update Docs & Guides
For UI-related changes
[X] Darkmode
[X] Responsive layout

reneaaron commented 4 months ago

Looks great so far, fixed some minor things directly.

1) Please have a look at the mobile styles for this new page:

2) 2 API calls every time you open the extension is a bit much, could we potentially merge them into one at least? (the internal API should return all of the information that the public API returns, anyway)

Otherwise this is a great change! :100:

tACK

pavanjoshi914 commented 4 months ago

merged api call into single. we only make internal api call now
updated types accordingly
added cache back
fixed responsiveness

pavanjoshi914 commented 4 months ago

tAck