getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

[BUG] Show account configured currency on my Alby Page #3157

Open ffrediani opened 6 months ago

ffrediani commented 6 months ago

Is there an existing issue for this?

Describe the bug

In my Alby settings I have my local fiat currency configured to convert from sats, however when accessing my Alby Page it shows the converted value in USD. Normally people accessing it may be from your own country it may be more convenient that by default it appears in the configured currency and not necessarily in USD.

To make it ideal it can either it can inherit it from the configured Extension account currency but it could optionally give the payer an option to show in his local currency in order to facilitate borderless transactions. Preferably an extra configuration option can be added to the Web version to set the default currency there so it doesn't depend on the Browser Extension.

Also when generating an invoice using the web version it shows it in USD instead of the local currency configured in the Browser Extension which the web version doesn't get it.

Screenshots [optional]

image

image

Steps To Reproduce

1 - Go to Extension Settings and check configured Currency (different from USD) 2 - Access you Alby Page and see that only shows converted value in USD

Expected behavior

Alby information

Device information

Additional context

No response

Are you working on this?

No

rolznz commented 6 months ago

Currently the currency set in the extension is not linked to getalby.com. However, I'm not sure if it makes sense on the tipping page, since you can receive tips from anyone worldwide.

ffrediani commented 6 months ago

Hi @rolznz Yeah, that´s why I mentioned that perhaps it can be a setting on the Alby page configuration of getalby.com

I see the tipping page as something beyond that that also works as a LN-URL link, but even looking at its usage for tipping in order to simply, if someone from my country is tipping me he still see the currency in USD and would be desirable to see in either then the default configured currency or the local currency the person chooses to display in order to facilitate.

Also and more importantly ideally the person should be able to type the amount in their currency and not only in satoshis.

ffrediani commented 3 months ago

@rolznz what would be the best way to implement it to show the fiat converted amount when entering the amount of sats (when generating an invoice for example) ? Otherwise the conversion has to be done in another app before entering on Getalby app.