getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
540 stars 194 forks source link

[BUG] NWC wallet not being connectable causes extension to hang #3189

Open DireMunchkin opened 4 months ago

DireMunchkin commented 4 months ago

Is there an existing issue for this?

Describe the bug

I noticed a problem with Alby when using it with Mutiny Wallet on multiple browsers / devices - The NWC secrets will sync cross device with Firefox Sync, so I.E. the secret for the Mutiny instance running on the laptop will end up on the tower PC. However if it then tries to connect to a Mutiny instance that's offline (like say the laptop that's powered off), the extension hangs and doesn't let you switch wallet to one that'd work.

Screenshots [optional]

No response

Steps To Reproduce

  1. Connect several NWC wallets to the extension.
  2. Switch off or disable the back-end for NWC for the wallet you're currently on.

Expected behavior

Expected: I'd expect to be able to switch wallet in the UI even if the wallet currently connected is offline. Actual behavior: The Wallet selector shows a spinner, and a stop sign symbol over the cursor, and doesn't let you switch wallet, you instead have to remove the non working wallet.

Alby information

Device information

Additional context

No response

Are you working on this?

No