chore: fix dark mode text color

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.

https://getalby.com/#extension

MIT License

540 stars 194 forks source link

chore: fix dark mode text color #3190

Closed im-adithya closed 4 months ago

im-adithya commented 4 months ago

Describe the changes you have made in this PR

Fixes unused classes

Type of change

(Remove other not matching type)

chore

How has this been tested?

Checklist

[x] Self-review of changed code
[x] Manual testing
[x] Added automated tests where applicable
[x] Update Docs & Guides
For UI-related changes
[x] Darkmode
[x] Responsive layout

pavanjoshi914 commented 4 months ago

from where those colors are referenced?

im-adithya commented 4 months ago

Those are used in PopIcons (see classes passed to Arrow Up and Down icons)

reneaaron commented 4 months ago

@im-adithya In the PR description you mention "Fixes unused classes", however it seems you just adjusted the colors. Also the new colors do not seem to match the figma designs?

im-adithya commented 4 months ago

I actually meant dark:color-green-400 dark:color-orange-400 which don't mean anything and are unused. I took the dark classes from above as I didn't find emerald and amber colors for dark mode (see popicon colors in dark mode here and here) as we would want to match the amount color to the arrow inside the icon