Closed bumi closed 3 years ago
working on it...got rid of the item.node error but many other things to fix...keep u updated
Seems we'll need to fork https://github.com/nitram509/macaroons.js & https://github.com/Tierion/lsat-js due to incompatibilities. Webpack 5 has removed automatic polyfill loading and it seems we need to add fallback resolve statements into those modules.
Module not found: Error: Can't resolve 'crypto' in '/home/korny/Development/WEBLN/lightning-browser-extension/node_modules/lsat-js/dist'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
- install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "crypto": false }
UPDATE: fixed that
no forking for crypto libraries! :D
the not so well documented alias and installing the polyfills manually solved this.
the extension reloader plugin seems to be the issue: it also seems that this package is not really maintained. wondering if there is an alternative we can use.
https://github.com/rubenspgcavalcante/webpack-extension-reloader/issues/110 https://github.com/rubenspgcavalcante/webpack-extension-reloader/issues/116
we could give https://github.com/webextension-toolbox/webextension-toolbox a spin
UPDATE: oh --> he's struggling updating to wp5 https://github.com/webextension-toolbox/webextension-toolbox/issues/309#issuecomment-729226633
lets see if we can find a webpack wizard instead
Currently we are using Webpack v4 (as provided by the extension boilerplate) we should update to v5. Maybe this also makes it easier to have good source maps? (#23 )
I tried to update all dependencies but getting the following error: