getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
540 stars 194 forks source link

Connect wallet screen could be higher placed #3204

Closed MoritzKa closed 3 months ago

MoritzKa commented 4 months ago

Is there an existing issue for this?

Describe the bug

Connect wallet screen could be higher placed or relatively higher for bigger screensizes.

Screenshots [optional]

chrome_F4O73DnZww

Steps To Reproduce

Navigate to the connect new wallet screen

Expected behavior

Closer to the top menu bar

Alby information

latest Alby release on a 26 inch screen

Device information

No response

Additional context

No response

Are you working on this?

None

pavanjoshi914 commented 4 months ago

@stackingsaunter shall we place this cards higher. currently they are centerally aligned for all screens. but for bigger screen sizes it seems it looks a bit off (as per moritz)

reneaaron commented 4 months ago

@pavanjoshi914 They should always be vertically centered on the screen. (that's what I see on the latest version, I can't seem to reproduce this behavior)

@MoritzKa Which browser are you using? Can you share a full-screen screenshot covering the whole screen? (so we can see the resolution)

MoritzKa commented 4 months ago

it is vertically centered. I was just surprised that there was such a distance between the menu bar and the graphic. And maybe also not a typical screen size. chrome_Aip7LO2jVz

pavanjoshi914 commented 3 months ago

I will close this. as i don't think we will be doing any changes here.