search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
540 stars 194 forks source link

edit SETUP.md for npm support #3213

Closed eesazahed closed 3 months ago

eesazahed commented 3 months ago

Hello there! Alby user here just checking out some open source stuff.

I noticed that there are yarn instructions, however it'd be quite useful for some devs to see instructions for npm on the project readme.

Describe the changes you have made in this PR

A clear and concise description of what you want to happen

Type of change

How has this been tested?

Ran the npm commands and got expected results

Checklist

reneaaron commented 3 months ago

Thanks for your PR!

Since nowadays there are a ton of package managers out there (yarn, npm, pnpm, etc.) and we can't cover them all in our README I would think developers will know to use their preferred package manager and apply these commands respectively, don't you think?

eesazahed commented 3 months ago

Yeah, you have a point that all of them can't be covered.

Do you think it would be better if I sent another PR in which theres just a note at the top highlighting that different package managers can be used in place of Yarn?