search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser extension that connects to different wallet interfaces and brings deep lightning integration to the web
https://getalby.com
MIT License
530 stars 193 forks source link

LNURL response notification is not shown in chrome #342

Closed bumi closed 2 years ago

bumi commented 2 years ago

In Firefox the LNURL response message (e.g. thanks for the payment) is shown as notification. In chrome I only see the payment success notification with the pre-image.

Maybe this is a bug, maybe this is only how my chrome notifications are configured?

dylancom commented 2 years ago

Chrome doesn't seem to like 2 notifications being spawned at the same time.

bumi commented 2 years ago

maybe we simply do a setTimeout and wait 500ms ? :)

MoritzKa commented 2 years ago

There also doesn't seem to be a notification after tipping on Firefox. For Chrome I did not encounter this issue described above.

dylancom commented 2 years ago

I tried to work with a timeout but that will make the first notification disappear directly when the new one appears (they don't stack). It also requires the window to stay open until the timeout fires (otherwise it won't fire at all). I guess the best solution is to show successAction message within the current screen and not closing the window.