getAlby / lightning-browser-extension

The Bitcoin Lightning Browser extension that connects to different wallet interfaces and brings deep lightning integration to the web
https://getalby.com
MIT License
522 stars 193 forks source link

transactionsList: implement incoming transactions on all connectors #46

Open chris-aeviator opened 3 years ago

chris-aeviator commented 3 years ago

Currently only the LND connector supports fetching payment history from the node.

Missing connectors:

Minor prio:

bumi commented 3 years ago

I think this is also a UX topic and we need to think about how and with which details we want to show the transactions. During the payment process we have more data like for example the website URL, Icon, etc. It might be nice to add that information and also be able to group the payments per website for example. e.g. this could allow us to answer the questions how much and for what a user paid on a specific domain.

That information needs to be stored locally as this is not part of the lightning invoice. I am also not sure what transactions details all connectors provide.

escapedcat commented 1 year ago

Can this be closed?

bumi commented 1 year ago

@escapedcat actually this is now very relevant again, isn't it? as you implementing showing incoming transactions we now still miss that function in some connectors

escapedcat commented 1 year ago

Adjusted title and first description

qqqzhch commented 1 year ago

I'm trying to build LNBits and lndhub locally to get test data,to see how different link transaction types are displayed。

I compared my operations and corresponding interface contents on Lightning Network Application and Ethereum Application

On the Ethereum application, more operations are transferred to tokens and linked wallets. so, the tab on the home page of Ethereum wallets mainly contains token lists and transfer records

In the lightning network application, more operations are login and transfer. The current home page tab only contains transfer records. These authorization operations related to the site are put on the website page.

Alby Wallet has many features related to the permission operation of the site. I think these should be very important features of the wallet and should be put on the home page,not on website page alby homepage tab1 is site operation tab2 Recent Transfer Records

qqqzhch commented 1 year ago

In metamask, it indicates whether there is a link between the current web page and the current account. It is displayed in a very important position

escapedcat commented 1 year ago

@qqqzhch I beleive we start to tackle what you describe in this PR: #1599
This is the start to change the general transaction list to an "event list".

This issue here is really only to implement the "incoming transactions" to all connectors which are missing this currently.

mviswanathsai commented 1 year ago

@escapedcat clarification, by incoming transactions you mean all the pending invoices that the user has to pay, right?

mviswanathsai commented 1 year ago

Could you assign this to me? I can try adding this to galoy and citadel connectors