search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
535 stars 193 forks source link

Command husky-run not found #47

Closed chris-aeviator closed 3 years ago

chris-aeviator commented 3 years ago

hey @bumi is it possible that branches I take from you include a githook that tries to find husky.sh? I cannot base any new commit ontop of https://github.com/bumi/lightning-browser-extension/pull/37 

❯ git commit
error Command "husky-run" not found.

EDIT: I actually have husky.sh in .git

bumi commented 3 years ago

I was complaining about that in the chat also. :) it is doing some linting in a pre-hook: https://github.com/bumi/lightning-browser-extension/blob/master/package.json#L33

I think this should not be a default and running yarn install should not automatically add git hooks. what do you think?