getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.

https://getalby.com/#extension

MIT License

536 stars 193 forks source link

Add support for LUD-18 email payer data #514

Closed bumi closed 2 years ago

bumi commented 2 years ago

We introduced LUD-18 support and currently support providing the name. Similar to the name we should also add support for users to provide an email address.

AustinKelsay commented 2 years ago

Hey @bumi I've been working on this today and think I have a solution, is there a good way to test this locally and confirm the username/email payer data is getting passed correctly?

AustinKelsay commented 2 years ago

541

bumi commented 2 years ago

Hey @AustinKelsay super cool!! thanks (sorry for the late reply).

I think you can test this using the lnurl playground: https://lnurl.fiatjaf.com/ This should support username/email payerdata.

Let me know if you need help. I will also test this asap!

AustinKelsay commented 2 years ago

Hey no problem @bumi I actually found this playground after searching around a bit and everything seems to work as expected with the payer data

bumi commented 2 years ago

ah, awesome, that's great to hear. so we should get your PR in soon. :shipit:

bumi commented 2 years ago

Yay, this is shipped!