getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
537 stars 194 forks source link

Distinguish between receiver and initiator of a payment #770

Closed reneaaron closed 2 years ago

reneaaron commented 2 years ago

Describe the bug See https://github.com/getAlby/lightning-browser-extension/pull/762#discussion_r839345174

The only situation where we know something about the receiver is when we pay to a lightning address in directly.

Use-Case Initiator Receiver
Pay to Lightning Adress Alby
Pay an invoice in Alby Alby
Pay via WebLN (Invoice) Website

The UI of Alby should reflect what we know about the payment being made.

Affected areas

To Reproduce

Pay an invoice in Alby

  1. Open Alby
  2. Paste an invoice

The UI currently indicates that one is paying to Alby, while Alby is only the initiator of the payment.

image image

Pay via WebLN

  1. Pay an invoice via WebLN

image

The UI currently indicates that one is paying to the website, while the website ist only the initiator of the payment.

Are you working on this issue? No

escapedcat commented 2 years ago

Looking into this.

Filling this would be helpful:

Expected behavior

A clear and concise description of what you expected to happen

bumi commented 2 years ago

maybe let's pair on this?

And I think this should be tackled when we do @dvoroneca new designs. One major topic here is that we don't show the Alby publisher card as seen in the screenshot above. (we currently do that because we reused a component that expects origin data that typically comes from the website that initiates the payment. )

so we must check which components are used in these flows and what we can reuse and what we need to adjust.

escapedcat commented 2 years ago