search

getAlby / lightning-browser-extension

The Bitcoin Lightning Browser Extension that brings deep Lightning & Nostr integration to the web. Wallet interface to multiple lightning nodes and key signer for Nostr, Liquid and onchain use.
https://getalby.com/#extension
MIT License
539 stars 194 forks source link

Support invoices without specified amount #823

Open reneaaron opened 2 years ago

reneaaron commented 2 years ago

Is your feature request related to a problem? Please describe. Currently invoiceless payments are not supported by Alby. A user reported he tried to donate to a BOLT-11 invoice generated on https://jb55.com/.

Decoding the invoice on lightningdecoder.com drew my attention to the amount field which is set to null: image

Currently there are 2 problems:

1) Clicking on a link lightning:lnbc10... does trigger the Alby popup but there is an ampty screen (an exception happened in the background)

2) Paying an invoice without a specified amount manually does not work as the amount is set to 0 and cannot be changed by the user:

image

Additional context The invoices can be paid by other wallets such as Phoenix. However, you'll see a warning that this is somewhat not safe and funds could be stolen in transit.

Are you working on this? No

kiwiidb commented 2 years ago

Incoming and outgoing transaction lists don't show the amount that was actually paid for a 0 amount invoice Schermafbeelding 2022-08-17 om 12 22 19

bumi commented 2 years ago

related #1070

rolznz commented 1 year ago

This is also an issue now for paying to Phoenix, if you don't edit the amount on the Phoenix side