Payments: logging & checks

getAlby / lndhub.go

Accounting wrapper for the Lightning Network. It provides separate accounts for end-users. (LndHub compatible API written in Go)

GNU General Public License v3.0

86 stars 23 forks source link

Closed kiwiidb closed 1 year ago

kiwiidb commented 1 year ago

[ ] check if invoice expired before trying to pay it
[ ] Check if right network
[ ] check destination is a LN pubkey
[ ] streamline the logging & Sentry notifications - check in the code for errors that aren't really errors and don't send these to Sentry (no_route, invalid_payment_details, ...)

reneaaron commented 1 year ago

Can we also add some more detailed information to the keysend payments in case the wallet couldn't be found?

It would be great to include the TLV records into the logs if no customKey / customValue was present. https://github.com/getAlby/lndhub.go/blob/fix/invoice-index/lib/service/invoicesubscription.go#L195