search

getAlby / lndhub.go

Accounting wrapper for the Lightning Network. It provides separate accounts for end-users. (LndHub compatible API written in Go)
GNU General Public License v3.0
86 stars 23 forks source link

payment finalizer: never break loop #383

Closed kiwiidb closed 1 year ago

kiwiidb commented 1 year ago

If we break the loop, then the queue will fill up. We cannot unbind the queue because then we could miss payments that happened while lndhub was offline. This means that we no longer have a need for the ticker - it's ok if our map never gets empty.

codecov[bot] commented 1 year ago

Codecov Report

Merging #383 (bec0544) into main (ea0ab4e) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   60.02%   60.06%   +0.03%     
==========================================
  Files          50       50              
  Lines        3212     3195      -17     
==========================================
- Hits         1928     1919       -9     
+ Misses       1078     1070       -8     
  Partials      206      206
Impacted Files Coverage Δ
rabbitmq/rabbitmq.go 55.98% <ø> (+0.20%) :arrow_up: