codecov[bot]
commented
1 year ago Codecov Report
Merging #386 (f4f83dc) into main (c6b94e0) will decrease coverage by
0.05%. The diff coverage is42.85%.
@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 60.06% 60.01% -0.05%
==========================================
Files 50 50
Lines 3195 3204 +9
==========================================
+ Hits 1919 1923 +4
- Misses 1070 1076 +6
+ Partials 206 205 -1 | Impacted Files | Coverage Δ | |
|---|---|---|
| controllers/keysend.ctrl.go | 45.56% <0.00%> (ø) |
|
| controllers_v2/keysend.ctrl.go | 35.87% <0.00%> (ø) |
|
| lib/service/service.go | 51.02% <ø> (ø) |
|
| lnd/lnd.go | 2.35% <15.38%> (+2.35%) |
:arrow_up: |
| integration_tests/util.go | 88.00% <25.00%> (+1.17%) |
:arrow_up: |
| integration_tests/lnd_mock.go | 81.69% <100.00%> (+0.35%) |
:arrow_up: |
| lib/service/invoices.go | 70.55% <100.00%> (ø) |
|
| lib/service/invoicesubscription.go | 59.62% <100.00%> (ø) |
|
| lib/service/user.go | 72.99% <100.00%> (ø) |
This PR prepares for a multi-LND backend by moving the "is this our pubkey?" checks to the LND client, so that it will also work with multiple backend nodes. For simplicity is also 1 "main" public key that acts as a placeholder public key to use for all incoming invoices, but this will not necessarily mean that these invoices will be generated by the node with that public key in case of multiple backend nodes.