search

getAlby / nostr-wallet-connect-next

Nostr Wallet Connect (NIP-47) application to allow apps to connect to your node
https://nwc.getalby.com
Apache License 2.0
8 stars 3 forks source link

feat: revamp new app screen #520

Closed im-adithya closed 10 hours ago

im-adithya commented 1 week ago

Fixes #394

rolznz commented 1 week ago

@im-adithya are there supposed to be both permissions and scopes components? shouldn't you have renamed the permissions file to scopes so that there is a nice diff of the changes?

I think we should merge https://github.com/getAlby/nostr-wallet-connect-next/pull/508 first as we need to fix an issue with BTCPayServer and then fix the conflicts here.

im-adithya commented 1 week ago

Yeah, I will. I left this in between to prioritize the Send/Receive.

I was thinking of removing the use of Permissions component and doing a normal forEach listing of scopes in the ShowApp screen. So after this PR, the Scopes component would only be there to extract the scope group boxes (refer new design) and checkboxes out of the NewApp screen, and all the other permissions logic would be in NewApp itself

im-adithya commented 10 hours ago

Closing in favor of #567