search

getAlby / nostr-wallet-connect

Nostr Wallet Connect (NIP-47) application to allow apps to connect to your node
https://nwc.getalby.com
Apache License 2.0
101 stars 29 forks source link

Add a replies table to store reply events #231

Closed im-adithya closed 5 months ago

im-adithya commented 5 months ago

Currently we only store the reply ID in the NostrEvent table (which are basically the received events of Kind NIP_47_REQUEST) after publishing a reply. Now that we are using an SQLite DB with #217, it's best to add a table to store these reply events early on to avoid having to migrate later.

Additional reasons are also mentioned here: https://github.com/getAlby/nostr-wallet-connect/pull/230

This also helps us in multi_methods (https://github.com/getAlby/nostr-wallet-connect/pull/218) as there we don't just have one reply per NostrEvent but multiple.

rolznz commented 5 months ago

@im-adithya we need to do this as part of https://github.com/getAlby/nostr-wallet-connect/pull/217 right? I will add a TODO there

EDIT: it needs to be done as part of https://github.com/getAlby/nostr-wallet-connect/pull/218 right?

im-adithya commented 5 months ago

Done here: https://github.com/getAlby/nostr-wallet-connect-next/pull/3