search

getAlby / nostr-wallet-connect

Nostr Wallet Connect (NIP-47) application to allow apps to connect to your node
https://nwc.getalby.com
Apache License 2.0
104 stars 31 forks source link

Kind 13194 info event does not match the spec #249

Closed gudnuf closed 7 months ago

gudnuf commented 7 months ago

When requesting the info event for an nwc created by nwc.getalby.com, the event content looks like this:

content: 'pay_invoice,pay_keysend,get_balance,get_info,make_invoice,lookup_invoice,list_transactions',

The spec says: "The content should be a plaintext string with the supported commands, space-separated, eg. pay_invoice get_balance."

Alby's info event contains a comma separated list.

TBH, I think that comma-separated makes more sense than space-separated. Everyone who is relying on the info event is probably already expecting a comma-separated list because Alby is the only one that has an info event with multiple methods.

Let me know if I should submit a PR to NIP 47

rolznz commented 7 months ago

@gudnuf thanks for raising this.

We actually just merged @benthecarman 's PR to fix this https://github.com/getAlby/nostr-wallet-connect/pull/247 but haven't merged it yet for the nwc.getalby.com deployment (https://github.com/getAlby/nwc.getalby.com/pull/5) and haven't pushed new versions of NWC to Umbrel/Start9 yet.

@benthecarman I tried to request this from mutiny and still only get one array item. So would changing the spec be better? I also agree comma separated makes more sense?

benthecarman commented 7 months ago

No we should not change the spec just because you guys had a bug, there are many implementation of nwc already and it's fixed in your guy's code.

rolznz commented 7 months ago

Ok. I will close this and plan to merge the nwc.getalby.com PR.