search

getAlby / website

DEPRECATED - no longer in use
https://getalby.com
2 stars 10 forks source link

Unify header #79

Closed secondl1ght closed 1 year ago

secondl1ght commented 2 years ago

Currently we have a different header on every page of the website which sort of makes it feel like you are navigating to a new site every time. Should we have the same header across all pages to improve this?

bumi commented 2 years ago

which header are you exactly talking about? logo and navigation of the public (not logged-in) pages?

secondl1ght commented 2 years ago

Yes that's the one I am talking about, do you think it would be good to unify the header for all of these pages?

bumi commented 2 years ago

yes, that should be a reusable component. At least for all the static pages in this repo. the dynamic part (the rails app) works differently, so that will not be unified.

secondl1ght commented 2 years ago

Ok I will make it unified at least for the non rails app then.

secondl1ght commented 2 years ago

PR in here https://github.com/getAlby/website/pull/132 and here https://github.com/getAlby/getalby.com/pull/136

jankoegel commented 1 year ago

We're soon shutting down this repo. Decided against keeping Remix in our tech stack.