getAlby / website

DEPRECATED - no longer in use
https://getalby.com
2 stars 10 forks source link

Remove duplicate install button component and create props for style #81

Closed secondl1ght closed 2 years ago

secondl1ght commented 2 years ago

Tracked in issue #80, I originally made another install button component for different styling. @bumi pointed out that we should use the same component and just add props to select the styling. So I have removed the new component and refactored the old one so that if you include style='plain' then it will use the plain styling.

secondl1ght commented 2 years ago

Note: I looked into this lint error and it looks like we need to add another package to fix this. Do we want to do this or remove this lint requirement?

image

bumi commented 2 years ago

why do you mean we would need to add a new package?

secondl1ght commented 2 years ago

@bumi nevermind I figured it out, all checks are passing now and this is ready for final review!