getamis / alice

Hierarchical Threshold Signature Scheme
Apache License 2.0
376 stars 75 forks source link

crypto/tss/ecdsa/cggmp/refresh: add validation of shares #247

Closed cychuang0924 closed 1 year ago

cychuang0924 commented 1 year ago

Before submitting a pull request, please make sure the following is done:

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01 :warning:

Comparison is base (30835ee) 80.59% compared to head (ebac30f) 80.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== - Coverage 80.59% 80.59% -0.01% ========================================== Files 143 143 Lines 11202 11212 +10 ========================================== + Hits 9028 9036 +8 - Misses 1369 1370 +1 - Partials 805 806 +1 ``` | [Impacted Files](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis) | Coverage Δ | | |---|---|---| | [crypto/binaryquadraticform/cache.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL2JpbmFyeXF1YWRyYXRpY2Zvcm0vY2FjaGUuZ28=) | `72.97% <ø> (ø)` | | | [crypto/bip32/child/hmac\_sha512.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL2JpcDMyL2NoaWxkL2htYWNfc2hhNTEyLmdv) | `94.95% <ø> (ø)` | | | [crypto/commitment/pedersen.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL2NvbW1pdG1lbnQvcGVkZXJzZW4uZ28=) | `27.27% <ø> (ø)` | | | [crypto/dbnssystem/dbns.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL2RibnNzeXN0ZW0vZGJucy5nbw==) | `93.33% <ø> (ø)` | | | [crypto/homo/cl/cl.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL2hvbW8vY2wvY2wuZ28=) | `62.71% <ø> (ø)` | | | [crypto/homo/paillier/paillier.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL2hvbW8vcGFpbGxpZXIvcGFpbGxpZXIuZ28=) | `83.78% <ø> (ø)` | | | [crypto/matrix/matrix.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL21hdHJpeC9tYXRyaXguZ28=) | `84.35% <ø> (ø)` | | | [crypto/zkproof/paillier/curve.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL3prcHJvb2YvcGFpbGxpZXIvY3VydmUuZ28=) | `100.00% <ø> (ø)` | | | [crypto/tss/ecdsa/cggmp/refresh/round\_3.go](https://codecov.io/gh/getamis/alice/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis#diff-Y3J5cHRvL3Rzcy9lY2RzYS9jZ2dtcC9yZWZyZXNoL3JvdW5kXzMuZ28=) | `58.51% <80.00%> (+1.71%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://codecov.io/gh/getamis/alice/pull/247/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getamis)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.