search

getamis / alice

Hierarchical Threshold Signature Scheme
Apache License 2.0
378 stars 74 forks source link

[CVE-2023-33241] Bitforge Vulnerability #267

Closed terenceyak closed 1 year ago

terenceyak commented 1 year ago

Hi Amis Team,

Recently FireBlocks published a vulnerability report named Bitforge related to TSS algorithms which use gg18 and gg20.

The report is published here.

I would like to find out if alice is exposed to this vulnerability, and if so will you guys be working on a fix?

Thanks,

Terence

fastchain commented 1 year ago

@terenceyak existence of this branch

https://github.com/getamis/alice/tree/fixGG18SecurityIssue

could be an answer to your question.

I'm not a member of Amis Team.

cychuang0924 commented 1 year ago

Hi all,

As @fastchain mentioned, we fix it in that PR.

To the best of our knowledge, there are two ways to address this issue.

  1. Add a zero-knowledge to fix it. Example: https://github.com/getamis/alice/blob/master/crypto/zkproof/paillier/nosmallfactoezkproof.go However, this is designed for CGGMP use and may not be very suitable for GG18.

So far, we still have found a suitable zero-knowledge proof.

  1. Check the small factors of public keys to avoid such attack. Here, we check 3000 primes, which does not divide the public key. As described in the white paper, choosing {p1, . . . , pn} = {6481, 6491, . . . , 6653}, Attack 4.11 extracts the key with probability 0.15 after 1.8 × 10^9 signatures (ref. Page 16). Here we check the prime is larger than 6481 (i.e. 27449).

If you have any suggestions, please let me know! Thanks!

fastchain commented 1 year ago

Hello @cychuang0924 !

Could you please confirm that bugs mentioned here

https://www.verichains.io/tsshock/

are fixed in Alice? Since there is no Alice in the list of affected vendors .

Thank you!

cychuang0924 commented 1 year ago

Hi all,

We have added explanations in Readme

https://github.com/getamis/alice/pull/272 about these issues, hoping it will be helpful to everyone. If there are any problems with the way they are handled, please feel free to let us know anytime. Thank you!

Sincerely,

Chih Yun

fastchain @.***> 於 2023年8月23日 週三 下午3:47寫道：

Hello @cychuang0924 https://github.com/cychuang0924 !

Could you please confirm that bugs mentioned here

https://www.verichains.io/tsshock/

are fixed in Alice? Since there is no Alice in the list of affected vendors .

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/getamis/alice/issues/267#issuecomment-1689457609, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4AJBGWXDRL4JVTKDRON2LXWWYS5ANCNFSM6AAAAAA3MLG6FI . You are receiving this because you were mentioned.Message ID: @.***>