search

getamis / eth-indexer

An Ethereum project to crawl blockchain states into database
GNU Lesser General Public License v3.0
233 stars 47 forks source link

Fix incorrect total balances #35

Closed markya0616 closed 6 years ago

markya0616 commented 6 years ago

The PR is fixed two issues:

  1. If it's a new subscriptions, the tx fee may be subtarcted twice.
  2. We may find the addresses of new subscriptions while we handle transfer events.
codecov-io commented 6 years ago

Codecov Report

Merging #35 into develop will decrease coverage by 0.02%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #35      +/-   ##
==========================================
- Coverage    43.32%   43.3%   -0.03%     
==========================================
  Files           20      20              
  Lines         1904    1905       +1     
==========================================
  Hits           825     825              
- Misses        1013    1014       +1     
  Partials        66      66
Impacted Files Coverage Δ
store/subscription/subscription.go 77.27% <100%> (ø) :arrow_up:
store/transfer_processor.go 70.12% <33.33%> (-0.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f182460...0f484a2. Read the comment docs.