search

getappmap / appmap-agent-js

This project is deprecated. Please use https://github.com/getappmap/appmap-node/ to record Node.js applications.
Other
28 stars 8 forks source link

Support for yarn projects #168

Open lachrist opened 1 year ago

lachrist commented 1 year ago

Yarn is an important package manager. And it is the one that we use for appmap-js. We should support yarn projects.

dividedmind commented 1 year ago

Also, pnpm.

dustinbyrne commented 1 year ago

What about yarn or other package managers is unsupported? Do we have specific tie ins with npm or npx?

dividedmind commented 1 year ago

@lachrist correct me if I'm wrong, but I believe the problem is that the agent parses the user-provided command line to figure out how to call and hook the project, and these heuristics only support npm at the moment; cf. https://github.com/getappmap/appmap-agent-js/blob/4ea08b38a953d7f89c2fac7a70adf27168931603/components/configuration-accessor/default/package.mjs#L48-L57

lachrist commented 1 year ago

Indeed. I haven't thought about supporting anything other than npm so I'm not sure what else is needed to support yarn. I suspect it is not much.