search

getappmap / appmap-agent-js

This project is deprecated. Please use https://github.com/getappmap/appmap-node/ to record Node.js applications.
Other
28 stars 8 forks source link

fix: wrap root function before exclusion #185

Closed lachrist closed 1 year ago

lachrist commented 1 year ago

Qualified name is required to exclude functions. And computing the qualified name assumes that there is no functions at the root level. So we need to wrap root level functions before exclusion.

dustinbyrne commented 1 year ago

If I'm understanding this correctly, root level functions will now be children of a package in all cases? I'll have to run this over @appland/scanner to validate.

lachrist commented 1 year ago

If I'm understanding this correctly, root level functions will now be children of a package in all cases? I'll have to run this over @appland/scanner to validate.

I'm not sure I understand. Basically, wrapRootEntityArray inserts a class between a package and all of its direct children if one of them is a function. So functions are guaranteed to have a class (not a package) as direct parent.

appland-release commented 1 year ago

:tada: This PR is included in version 13.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: