getappmap / appmap-java

AppMap client agent for Java
Other
81 stars 15 forks source link

Record http_client_request events when using Apache's HttpClient library #174

Closed apotterri closed 1 year ago

apotterri commented 1 year ago

Note that this PR does not add support for configuring the recording of getters. However, as the new test case shows, if a getter makes an HTTP request (using HttpClient), it will show up in the recording.

Fixes #172.

apotterri commented 1 year ago

Looks good. Should this be a feature instead of a fix?

I went back and forth as to which it should be. But, since it made you wonder, I changed it to feature.

appland-release commented 1 year ago

:tada: This PR is included in version 1.17.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: