search

getappmap / appmap-java

AppMap client agent for Java
Other
80 stars 14 forks source link

URL domain in generated appmap.yml comment needs to be appmap.io #216

Closed brikelly closed 12 months ago

brikelly commented 12 months ago

https://github.com/getappmap/appmap-java/blob/c89265369ecdc8016645bb59d4fcba6f6f99bafd/agent/src/main/java/com/appland/appmap/config/AppMapConfig.java#L189C87-L189C87

The link still works, but we should change it.

Sweetdevil144 commented 12 months ago

Hello @brikelly. I would like to work on this issue!!

Sweetdevil144 commented 12 months ago

Is this issue open?

brikelly commented 12 months ago

Hi @Sweetdevil144 , sure, as an open source company we are happy to accept PRs

Sweetdevil144 commented 12 months ago

The issue is fixed. Following changes were made :

pw.println("# https://appland.com/docs/reference/appmap-java.html#configuration");

was converted to

pw.println("# https://appmap.io/docs/reference/appmap-java.html#configuration");
appland-release commented 11 months ago

:tada: This issue has been resolved in version 1.22.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: