search

getappmap / appmap-java

AppMap client agent for Java
Other
80 stars 14 forks source link

Request recordings should not occur for media assets downloads #231

Closed brikelly closed 10 months ago

brikelly commented 10 months ago

Currently, Java request recordings show up or all kinds of CSS, image, and HTML GET requests. These are noisy and should be disabled.

kgilpin commented 10 months ago

This is configured in the client tooling, e.g. the diagrams and scanner, we don't require the Agent to make this distinction.

If "Hide media requests" is not working in the AppMap diagram, then the bug is in the UI.

brikelly commented 10 months ago

It's not the Hide media requests control I'm referring to, though - it's the fact that lots of per-request maps for media requests get created and then show up in our AppMap list in the UI, and create more work for the indexer and scanner to deal with.

For example:

Screenshot 2023-10-13 at 6 58 11 PM

All that said, I just updated the Java agent that IntelliJ was using and it looks a whole lot better. The only asset-like request was the one for vets.html in the graphic above, and that map shows a call to the DB to retrieve some of the content, so it's a legit map to record. @apotterri did you happen to fix this issue recently?

brikelly commented 10 months ago

Here's how things look like in Python / Flask:

Image

So I think I just mis-remembered which language this issue was present in. I'll file this as a Python issue and close this one.

apotterri commented 10 months ago

Actually, it was broken for Java as well. I fixed it for Spring apps in v1.20.1. It's still broken for other frameworks, though. Dunno whether you want to reopen it based on that?

kgilpin commented 10 months ago

Ok. We could also fix this in the code editor. For example browser debugger tools will have an option to hide media requests. Getting this right in all the agents and frameworks is going to be hard.