getappmap / appmap-js

Client libraries for AppMap
49 stars 17 forks source link

Sequence Diagram has a legend #1066

Closed Daniel-Warner-X closed 1 year ago

Daniel-Warner-X commented 1 year ago

When a user clicks on the 'i' icon in the lower right hand corner of the Dependency Map or Trace View, they get a legend explaining what the different visual indicators on the map mean.

Image

Image

The Sequence Diagram is not included in this information. Clicking the 'i' icon in the Sequence Diagram view produces the same double legend that is used for the Dependency Map and Trace View.

Quick fix would be to add legend content for the Sequence Diagram. Better solution would be to have the 'i' icon produce a context-specific legend for the visualization that the user is looking at.

kgilpin commented 1 year ago

This seems a bit less important than with the other diagrams since sequence diagram is a standard that we are following.

I wonder if linking out to web docs would be better anyway. The legend tends to obscure the diagram that the user is trying to look at.

On Thu, Feb 23, 2023 at 10:09 AM Daniel Warner @.***> wrote:

When a user clicks on the 'i' icon in the lower right hand corner of the Dependency Map or Trace View, they get a legend explaining what the different visual indicators on the map mean.

[image: Image] https://user-images.githubusercontent.com/1229326/220978613-99a06635-eaf7-42a0-8194-0d8810b8851e.png

[image: Image] https://user-images.githubusercontent.com/1229326/220978747-e8b94e67-3c90-4aa4-af51-2a14ba8fbb4a.png

The Sequence Diagram is not included in this information. Clicking the 'i' icon in the Sequence Diagram view produces the same double legend that is used for the Dependency Map and Trace View.

Quick fix would be to add legend content for the Sequence Diagram. Better solution would be to have the 'i' icon produce a context-specific legend for the visualization that the user is looking at.

— Reply to this email directly, view it on GitHub https://github.com/getappmap/appmap-js/issues/1066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC65AHHECCWWR6XW5KNDWY6KTBANCNFSM6AAAAAAVF4VYQI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

appland-release commented 1 year ago

:tada: This issue has been resolved in version @appland/components-v2.32.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: