getappmap / appmap-js

Client libraries for AppMap
49 stars 17 forks source link

Installer appears to downgrade appmap-python #1147

Open kgilpin opened 1 year ago

kgilpin commented 1 year ago

https://github.com/land-of-apps/Promptify/actions/runs/4723196250/jobs/8378820788

AppMap language library has been installed and configured.
git add -N .
git diff > .appmap/appmap-install.patch
Patch file contents:
diff --git a/requirements-dev.txt b/requirements-dev.txt
index 6f2d6e2..a5d4350 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -1,4 +1,4 @@
-appmap==1.15.0
+appmap>=1.1.0.dev0
 black==22.12.0
 isort==5.11.4
 flake8==6.0.0
kgilpin commented 1 year ago

@petecheslock @apotterri do you think there's anything to worry about here, or should I close this?

apotterri commented 1 year ago

Well, it doesn't seem great to modify a requirements file that already contains appmap. Modifying it to relax the version restriction feels like adding insult to injury. ;)