Merge system messages everywhere

getappmap / appmap-js

Client libraries for AppMap

45 stars 12 forks source link

Closed dividedmind closed 1 week ago

dividedmind commented 1 week ago

Fixes #1860

This was caused by two problems:

system message merging (which is done to make sure to support engines which only accept a single system message) was only applied in explain,
examples given in vector terms prompt mistakenly used system role instead of assistant.

petecheslock commented 1 week ago

@dividedmind I've tested this branch and now my queries to anyscale are working correctly

dividedmind commented 1 week ago

@dividedmind I've tested this branch and now my queries to anyscale are working correctly

Awesome, thanks! Merging.

appland-release commented 1 week ago

:tada: This PR is included in version @appland/navie-v1.16.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kgilpin commented 1 week ago

FYI this didn't seem to trigger a release of appmap -

➤ YN0000: [@appland/appmap]: [3:27:56 PM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

So I don't think users will be picking up this change.