search

getappmap / appmap-js

Client libraries for AppMap
48 stars 17 forks source link

fix: Adjust the first line of a patch when it has 0 indent #2097

Closed kgilpin closed 3 weeks ago

kgilpin commented 3 weeks ago

Fixes https://github.com/getappmap/appmap-js/issues/2095

dividedmind commented 3 weeks ago

I don't think this actually works... let me double check. I had a simpler solution in mind, if this doesn't work then I'll try mine, ok? (Especially seeing you went ahead and worked on it even though I grabbed it ;P)

kgilpin commented 3 weeks ago

Yeah, it doesn't. Try your way.

dividedmind commented 3 weeks ago

Yeah, it doesn't. Try your way.

I will. For now I pushed a commit here that makes the tests more robust so it's apparent that it doesn't work.

dividedmind commented 3 weeks ago

Another approach at #2100