search

getappmap / appmap-js

Client libraries for AppMap
49 stars 17 forks source link

Provide a better `npx` command for recording that works across shells in Windows #820

Closed ahtrotta closed 2 years ago

ahtrotta commented 2 years ago

When users use a non-default terminal (e.g. git bash) for Windows, the Windows path separators get ignored and the directory path becomes invalid. From this log%20and%20customDimensions%5B%22appmap.cli.sessionId%22%5D%20contains%20%2252db75457fa220e77d5e6c584fc73cea2ca54253ab3e00f42e05c14dcd670d18%22%7C%20extend%20logLen%3Dstrlen(customDimensions%5B%22appmap.cli.log%22%5D)%2Clog%3DcustomDimensions%5B%22appmap.cli.log%22%5D%7C%20project-reorder%20%20timestamp%2Cname%2Cuser_Id%2ClogLen%2Clog), a command similar to this was run:

node_modules\@appland\appmap\built\cli.js record test -d c:DevelopmentMyOrgMyApp

Resulting in this error:

ENOENT: no such file or directory, chdir 'C:\Development\MyOrg\MyApp' -> 'c:DevelopmentMyOrgMyApp'
appland-release commented 2 years ago

:tada: This issue has been resolved in version @appland/components-v2.18.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: