search

getappmap / appmap-node

AppMap client agent for Node.js
Other
10 stars 4 forks source link

Fixes for dots in paths and relative paths #108

Closed dividedmind closed 9 months ago

dividedmind commented 10 months ago

Fixes #104 Fixes #100

@dustinbyrne could you please verify this fixes your issues?

dividedmind commented 10 months ago

It's close, but I'm still getting relative paths in some cases. See the package names and path displayed in the attached image. image

Including the AppMap here as well. 2024-02-02T19:36:03.267Z_-v1-ai-speak.appmap.zip

I'm going to need some help to reproduce this.

Edit: I took a look at the appmap; it's super weird. I want to understand better what's happening there and I'd love to reproduce it. (BTW, where are you running what from, where are your appmap.ymls and package.jsons?)

dustinbyrne commented 10 months ago

Here's a basic reproduction of the issue. See the README for running instructions. https://github.com/dustinbyrne/appmap-node-108-repl

dividedmind commented 9 months ago

@dustinbyrne should work now, can you take a look? thanks!

appland-release commented 9 months ago

:tada: This PR is included in version 2.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: