search

getappmap / appmap-node

AppMap client agent for Node.js
Other
10 stars 4 forks source link

fix: Check if recordings are still active after promise resolution and callbacks #139

Closed zermelo-wisen closed 6 months ago

zermelo-wisen commented 7 months ago

There was an issue with some generated appmaps, which resulted in the error bellow in the VS Code AppMap viewer - the spinner kept spinning.

The problem arose from the parent_id of certain event update objects (members of the eventUpdates array) not matching a call event in the same appmap. In some cases, an appmap had finished, and a new one had been created by the time a promise was resolved, leading to the creation of a fix-up event in the wrong appmap.

This fix verifies whether we are in the correct appmap and skips the fix-up process if not.

image image
dividedmind commented 6 months ago

@zermelo-wisen this needs to be updated for multi-recording.

zermelo-wisen commented 6 months ago

@zermelo-wisen this needs to be updated for multi-recording.

Done.

appland-release commented 6 months ago

:tada: This PR is included in version 2.21.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: