search

getappmap / appmap-ruby

AppMap client agent for Ruby
https://appland.org
Other
100 stars 13 forks source link

fix: Rescue exceptions when calling Class#to_s #235

Closed apotterri closed 2 years ago

apotterri commented 2 years ago

Calling #to_s on Rails internal classes (e.g. those used for associations) may raise an exception. Fall back to using the class name if that happens.

These changes also add a minimal Rails 7 app for testing. This app is complete enough to show that the #to_s fix works, but not enough to claim that we should claim Rails 7 support.

Fixes #226.

kgilpin commented 2 years ago

Is it worth having an ignore list of classes that are known to have bad behaving to_s?

On Mon, Mar 28, 2022 at 8:36 AM Alan Potter @.***> wrote:

Calling #to_s on Rails internal classes (e.g. those used for associations) may raise an exception. Fall back to using the class name if that happens.

These changes also add a minimal Rails 7 app for testing. This app is complete enough to show that the #to_s fix works, but not enough to claim that we should claim Rails 7 support.

You can view, comment on, or merge this pull request online at:

https://github.com/applandinc/appmap-ruby/pull/235 Commit Summary

File Changes

(93 files https://github.com/applandinc/appmap-ruby/pull/235/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/applandinc/appmap-ruby/pull/235, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC635SKVHC3HMNLZWEIDVCGRTRANCNFSM5R3ACJYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

appland-release commented 2 years ago

:tada: This PR is included in version 0.77.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: