search

getappmap / appmap-ruby

AppMap client agent for Ruby
https://appland.org
Other
100 stars 13 forks source link

fix: Allow appmap_dir, language and additional properties #249

Closed kgilpin closed 2 years ago

kgilpin commented 2 years ago

I think at the top level, definitely, so the AppMap config can be extended. But within sections like packages and functions, it makes sense to be strict so that we catch spelling errors and stuff like that.

On Thu, May 5, 2022 at 9:03 AM Alan Potter @.***> wrote:

@.**** requested changes on this pull request.

In config-schema.yml https://github.com/applandinc/appmap-ruby/pull/249#discussion_r865880849 :

@@ -1,10 +1,14 @@ type: object -additionalProperties: false +additionalProperties: true

It seems like we should set additionalProperties to true everywhere.

WDYT?

— Reply to this email directly, view it on GitHub https://github.com/applandinc/appmap-ruby/pull/249#pullrequestreview-963325958, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC66L44QK25W642FIYY3VIPBKVANCNFSM5VE5IDGQ . You are receiving this because you authored the thread.Message ID: @.***>

appland-release commented 2 years ago

:tada: This PR is included in version 0.83.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: