search

getappmap / appmap-ruby

AppMap client agent for Ruby
https://appland.org
Other
100 stars 13 forks source link

fix: Exclude AppMaps from the gem when packaging #259

Closed apotterri closed 2 years ago

apotterri commented 2 years ago

If there are AppMaps in the gem, the VS Code extension's Install Guide sees them and thinks recordings have been made.

kgilpin commented 2 years ago

@apotterri I guess it's only an issue if the gem is vendored?

appland-release commented 2 years ago

:tada: This PR is included in version 0.83.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

apotterri commented 2 years ago

@apotterri I guess it's only an issue if the gem is vendored?

Yeah, it's an issue if the gem gets installed somewhere under the root of the project.

I'm managing versions of my dev tools (ruby, python, java, node) with asdf, using the direnv. I really like the fact I don't wind up with a project's dependencies sprayed all over my filesystem. Everything winds up in .direnv in the root of the project, so cleanup is super-simple.

kgilpin commented 2 years ago

OK, if you put .direnv in your Find: Exclude and Watch: Exclude settings you'll get the same result.

On Wed, Jun 22, 2022 at 5:15 PM Alan Potter @.***> wrote:

@apotterri https://github.com/apotterri I guess it's only an issue if the gem is vendored?

Yeah, it's an issue if the gem gets installed somewhere under the root of the project.

I'm managing versions of my dev tools (ruby, python, java, node) with asdf https://asdf-vm.com/, using the direnv https://github.com/asdf-community/asdf-direnv. I really like the fact I don't wind up with a project's dependencies sprayed all over my filesystem. Everything winds up in .direnv in the root of the project, so cleanup is super-simple.

— Reply to this email directly, view it on GitHub https://github.com/applandinc/appmap-ruby/pull/259#issuecomment-1163607255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC664C6CT64RPLEO4X53VQN67XANCNFSM5ZQNDHIA . You are receiving this because you modified the open/close state.Message ID: @.***>