getappmap / appmap-ruby

AppMap client agent for Ruby
https://appland.org
Other
100 stars 13 forks source link

feat: Don't record rspec tests when appmap: false #266

Closed kgilpin closed 2 years ago

kgilpin commented 2 years ago

Nope - too much TS I guess!

On Tue, Aug 9, 2022 at 2:36 PM Alan Potter @.***> wrote:

@.**** approved this pull request.

One comment, but looks good otherwise.

In lib/appmap/rspec.rb https://github.com/applandinc/appmap-ruby/pull/266#discussion_r941682925 :

   end
   def end_spec(example, exception:)
     recording = @recordings_by_example.delete(example.object_id)
     return warn "No recording found for #{example}" unless recording
  • recording.finish exception
  • recording.finish exception unless recording === :false

Did you mean to use === here?

— Reply to this email directly, view it on GitHub https://github.com/applandinc/appmap-ruby/pull/266#pullrequestreview-1067213442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC652P7SFNKIZ4P5XI2LVYKQLDANCNFSM56BYAIXQ . You are receiving this because you authored the thread.Message ID: @.***>

appland-release commented 2 years ago

:tada: This PR is included in version 0.86.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: