search

getappmap / appmap-ruby

AppMap client agent for Ruby
https://appland.org
Other
100 stars 13 forks source link

feat: Emit metadata.recorder.type #284

Closed kgilpin closed 2 years ago

kgilpin commented 2 years ago

Supports AppMap version 1.9.0

https://github.com/applandinc/appmap/pull/32

kgilpin commented 2 years ago

Good point. What's going on here is that 2.5 is generally known to work, but we won't support it with are version-specific specific bug fixes, since it's deprecated by the Ruby dev team

On Mon, Sep 19, 2022 at 2:03 PM symwell @.***> wrote:

@.**** approved this pull request.

In lib/appmap/version.rb https://github.com/applandinc/appmap-ruby/pull/284#discussion_r974532117 :

  • APPMAP_FORMAT_VERSION = '1.7.0'
  • APPMAP_FORMAT_VERSION = '1.9.0'

SUPPORTED_RUBY_VERSIONS = %w[2.5 2.6 2.7 3.0 3.1].freeze

Wondering if AppMap is deprecating support for Ruby 2.5 after seeing this https://github.com/applandinc/appmap-ruby/pull/282/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485L8 change in a different pr. Doesn't need to happen in this pr.

— Reply to this email directly, view it on GitHub https://github.com/applandinc/appmap-ruby/pull/284#pullrequestreview-1112663192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVC63L3VSB2XTH766UHOTV7CTHVANCNFSM6AAAAAAQQKLTFI . You are receiving this because you authored the thread.Message ID: @.***>

appland-release commented 2 years ago

:tada: This PR is included in version 0.91.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: