If we want to have recording by default, I think this makes more sense and is what user would expect: appmap is enabled by default whenever tests are run, regardless of environment variables (which might not even be set, even for example for rails — it only uses them as one input to determine environment).
It can still be disabled with APPMAP=false or APPMAP_RECORD_RSPEC=false.
If we want to have recording by default, I think this makes more sense and is what user would expect: appmap is enabled by default whenever tests are run, regardless of environment variables (which might not even be set, even for example for rails — it only uses them as one input to determine environment).
It can still be disabled with
APPMAP=false
orAPPMAP_RECORD_RSPEC=false
.Fixes #288